Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build errors Win 10 #48

Closed
BLMTuan opened this issue Jan 10, 2018 · 8 comments
Closed

Build errors Win 10 #48

BLMTuan opened this issue Jan 10, 2018 · 8 comments

Comments

@BLMTuan
Copy link

BLMTuan commented Jan 10, 2018

Issue Description

untitled

I followed all the steps but still cant build it right

Debug information

  • Els_kom version: [1.4.9.8]
  • OS: [win 10 Home]
  • OS Arch: [Your OS Arch here]
  • OS Build: [Your OS Build here]

Note: Newer versions from time to time ship with a newer version of python embedded.

Fix suggestion

@BLMTuan
Copy link
Author

BLMTuan commented Jan 11, 2018

' ')?

@Squididly
Copy link

I also got the same error but what I did was instead of running the build.bat i opened the pcbuild.sln and built it from there
image
then you would build the kom extractor

@Squididly
Copy link

however i recommend just using these in the meanwhile
kom.tools

@AraHaan
Copy link
Contributor

AraHaan commented Jan 14, 2018

I recommend trying the kom-rework branch, however that branch is sadly not complete yet, and seems to crash on zlib when decompressing as an stream and not an file... 🤔

However because it is not complete I do at the same time do not recommend it due to possible data loss from kom v2 as it seems for some reason overflow the entry count. resulting in eventual crashes in itself, and kom v4 which results in instant crashes because of something I am unsure about.

Also sorry for the late reply as it also seems my laptop is giving me even more issues... I wish I could easily replace it without losing important personal files I need.

Not only that but I am also thinking of some sort of plugin system to unpack and algorithm 2 and 3 for kom v3 that would just so happen to work for kom v4 as well as kom v4 seems to share most of v3. Also when I was reversing the koms from the original python code to v3 (when all of Elsword’s koms was v3) I discovered they packed to specific algorithms based on the file extension in an target folder that generates an target kom file. And so I plan to make that work similarly here as well but this means I would need to test them to see if it works too well so that way it can be updated at an moment’s notice. So, for that reason the implementation of kom-rework until done is an release blocker because it needs to be up to par with the original python code that should do the packing and unpacking. The other issue is after that porting the C# code for this for an xmplay plugin supporting the kom file for any xmplay playable files from within the kom files as algorithm 0 similar to how it loads up qll playable files and queues them from an zip file being dragged into that program.

Also build.bat on cpython fir master here is not the only way either. One can also open up their pcbuild.sln file to build python manually in visual studio 2017 if build.bat does not work.

@AraHaan
Copy link
Contributor

AraHaan commented Jan 15, 2018

Alright I just pulled some updates to things like an start to an autogenerated changelog and an update to the templates on github to hopefully make it much easier to manage. I will update the code and actually fill in the changelog entry items as soon as I can and finush up the reimplementation. After that I hope all would be ok.

@AraHaan
Copy link
Contributor

AraHaan commented Jan 19, 2018

@BLMTuan, @Squididly due to issues with my laptop that has some uncommited changes to the core that implements kom v2, v3, and v4 (with some local fixes to fix an v3 and v4 crash with zlib) however combine that woth an entry overflow with kom b2 I got no idea how I can fix the entry count for v2 for it to work like the python v2 implementation. 🤔 However I am trying and my laptop is the reason why I put issue #47 on hold for now. Also after some thoughts the plan for 1.5.0.0 has changed from implement algorithm 2 and 3 support to providing algorithm 2 and 3 support via 3rd party plugins. However loading and invoking them might be an challenge. I think since I hopefully can get zlib built into the core working right to basically have the plugins only do the per kom encryption/decryption with the function taking in the file stream and the name of the folder that is being packed to identify the kom that is being packed for the proper encryption keys. Also knowing that is based on file extensions in the unpacked kom target folder that can be hard coded into the core that would theb invoke the proper encryption / decryption. In fact then VoidEls could then provide an plugin for specific kom files for mods (like character or voice kom files) easily then.

@AraHaan
Copy link
Contributor

AraHaan commented May 21, 2018

Alright so, anyone here would like to join the organization? I do not care really who joins and plus then you can make changes in branches directly instead of needing to make forks.

@AraHaan
Copy link
Contributor

AraHaan commented Jun 2, 2018

Pushed the kom-rework branch to master, however some of the kom plugins might look to be incomplete because they are. This was because I had to get rid of the old python stuff as soon as possible. Also I plan merging the legacy repository into a legacy branch which would be an orphan branch having no commits from master. Also seems that building only works in clones for now.

@AraHaan AraHaan closed this as completed Jun 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants