Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modrinth shows that only minecraft 1.7.2 is supported #152

Open
FeeeeK opened this issue May 11, 2024 · 3 comments
Open

Modrinth shows that only minecraft 1.7.2 is supported #152

FeeeeK opened this issue May 11, 2024 · 3 comments
Labels
Feature Request New feature or request

Comments

@FeeeeK
Copy link

FeeeeK commented May 11, 2024

Currently only version 1.7.2 marked as supported in metadata:

game_versions: 1.7.2

This breaks any plugin auto-update tool. Unfortunately modrinth doesn't support version ranges, so the only option is to list all versions comma separated as specified in the workflow's README

@FeeeeK FeeeeK added the Feature Request New feature or request label May 11, 2024
@FeeeeK
Copy link
Author

FeeeeK commented May 11, 2024

Same issue with any other Limbo* plugin

@SkyWatcher2019
Copy link
Member

  1. Don't use autoupdaters, any plugin or core may have broken things.
  2. Autoupdaters should check plugin's version instead of game version, don't you think?

@FeeeeK
Copy link
Author

FeeeeK commented May 11, 2024

This answer does not solve the problem with incorrect plugin's metadata.

  1. Just because plugins are sometimes broken doesn't mean I can't use autoupdaters. It saves me a lot of time because it's much easier to write one command or restart docker container than to check and download every plugin, don't you think?
  2. No, they absolutely should check supported minecraft version, like they do it for mods. This is whole point of this data existence on modrinth. And even for people, can you tell me, which version between 1.1.0 and 2.3.1 supports mc 1.20.1? Probably not, that's why mc version metadata is needed.

@mdxd44 mdxd44 reopened this May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants