Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ability To Ignore Path Wildcard Dependencies #448

Closed
AldaronLau opened this issue Aug 16, 2022 · 1 comment · Fixed by #487
Closed

Add Ability To Ignore Path Wildcard Dependencies #448

AldaronLau opened this issue Aug 16, 2022 · 1 comment · Fixed by #487
Labels
enhancement New feature or request

Comments

@AldaronLau
Copy link

Is your feature request related to a problem? Please describe.
Yes, I would like to use wildcards = "deny", but only for non-path-based dependencies.

Describe the solution you'd like
Add a config option to specify whether wildcard checks apply to repository-local dependencies, preferably the default is no.

Describe alternatives you've considered
Change behavior to not apply wildcard checks to dependencies specified by path.

Additional context
None
@AldaronLau AldaronLau added the enhancement New feature or request label Aug 16, 2022
@alice-i-cecile
Copy link

alice-i-cecile commented Nov 24, 2022 •
edited
Loading

Running into this in DioxusLabs/taffy#258, where I'm attempting to enable features for tests and examples using dev-dependencies. I can set a fixed version, but can't publish my crate with it.

@sribich sribich mentioned this issue Dec 19, 2022
Merged
mergify bot pushed a commit that referenced this issue Dec 20, 2022
@sribich @Jake-Shadle
Add option to allow wildcard path dependencies (#487)
05e1b34 
* Add option to allow wildcard path dependencies

Adds an `allow-wildcard-paths` option for the `bans` check
which will allow path dependencies to use wildcard versions
if the crate is private or the dependency is a dev-dependency.

Closes issue #448

* Rustfmt

* Fix clippy lints

* Ignore atty advisory

* Oops

* Ignore wildcard paths in git sources

Co-authored-by: Jake Shadle <jake.shadle@embark-studios.com>
@mergify mergify bot closed this as completed in #487 Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add option to allow wildcard path dependencies
2 participants
@alice-i-cecile @AldaronLau