-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try to maintain Fixes #...
messages from squashed commits?
#20
Comments
We prioritised getting the PR description for the squash commits as that is the main thing one has when the branch has multiple commits. Could be possible for single-commit branches/merges to somehow combine the PR description with the commit description, or just use the commit description - but we often had more detailed PR descriptions than the commit descriptions so does sound a bit tricky and that one may have to just pick either or. So the PR should have the "Fixes XX" strings also right, as otherwise the PR won't be linked and close the issues it is fixing, are you saying here that Octobers removes those lines from the PR description? |
Not quite. In my case, the PR didn't have the |
Ah but don't you have to have the "Fixes XX" in the PR description though for GitHub to link the PR with the issue, and close the issue when the PR is merged? Or does it find that a commit in the PR branch referenced it and close the referred issue when it is merged? |
AFAIR github will only auto close if it's in the PR description, it will only show that an issue was referred from via a commit. |
It also works when the |
When working a pull request, developers may embed
Fixes #...
annotations within commit messages. Right now it seems that when octobors squashes commits, it uses the pull request's description as the commit message. As a result this will lose the annotations from the commit messages by default. It would be nice if it had the ability to parse the commit messages from the pull request, and keep these annotations in the final squashed commit's message.The text was updated successfully, but these errors were encountered: