-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1793 kill liuggio #144
1793 kill liuggio #144
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mainly one change
} | ||
|
||
/** | ||
* @expectedException \InvalidArgumentException |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this annotation is deprecated: sebastianbergmann/phpunit#3332
the reason is written here: https://thephp.cc/news/2016/02/questioning-phpunit-best-practices
src/FileFormat/ExcelConverter.php
Outdated
* @param string $filename filename to give to the download | ||
* @param string $format format of write (like Excel2007) | ||
* @param string $contentType mime content type | ||
* @param PhpOffice\PhpSpreadsheet\Spreadsheet $spreadsheet Excel object to create the download from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need for the namespace. The class has a use statement, and this is used in phpdoc as well.
@@ -94,40 +72,47 @@ public function fromHtml($html, $selector = null) | |||
|
|||
$tmpFile = $this->getTempHtmlFile($htmlStr); // as temporary file because it must have a filename | |||
|
|||
return $this->getExcelService()->createPHPExcelObject($tmpFile['path']); | |||
return IOFactory::load($tmpFile['path']); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
src/FileFormat/ExcelConverter.php
Outdated
$writer->save('php://output'); | ||
}, | ||
200, | ||
[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see. The headers are set later. So it is fine. We could skip this arg entirely ([] is the default).
@@ -1,104 +0,0 @@ | |||
<?php |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is not used in pa nor in tm, so 👍 to delete it
Use class name in phpdoc, because there is a use statement for it. Set a valid spreadsheet type in phpdoc.
see https://github.com/EmchBerger/projectassistant/issues/1793
Remove Liuggio/ExcelBundle, which requires the abandoned PHPOffice/PHPExcel bundle.
Remove ExcelReader service, which is not used.