Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in SmokeEffect #37

Closed
SwiftyAlex opened this issue Nov 29, 2023 · 5 comments
Closed

Crash in SmokeEffect #37

SwiftyAlex opened this issue Nov 29, 2023 · 5 comments

Comments

@SwiftyAlex
Copy link

SmokeEffect references a couple particle images which aren't there, causing a forced crash with an unwrap.

The assets for the package only contains "anvil_smoke_gray" and "anvil_smoke_white", but the effect references the below:

    let particles = [
        "anvil_smoke_gray",
        "anvil_smoke_gray_blur",
        "anvil_smoke_gray_alt",
    ]
Assets
Screenshot 2023-11-29 at 16 25 07
@robb
Copy link
Contributor

robb commented Nov 29, 2023

Good catch, we're looking into it.

@mergesort
Copy link
Collaborator

@SwiftyAlex I have a fix ready but am waiting on a fix to a permissions issue that's preventing me from pushing code to the main branch. When that's settled the smoke effect will work again, in the mean time I appreciate your patience! 🙇🏻‍♂️

@SwiftyAlex
Copy link
Author

Oooh fantastic, thanks both

I would have loved to help myself but could only guess what they were supposed to look like - can hopefully return the favour one day! 😄

@mergesort
Copy link
Collaborator

@SwiftyAlex This should now be fixed in 1.0.1, would love to confirm that it's fixed for you!

@SwiftyAlex
Copy link
Author

lookin' real smokey 💨

Simulator.Screen.Recording.-.iPhone.15.-.2023-11-30.at.21.08.06.mp4

thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants