Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Don't crash on errors #25

Closed
TheFrenchGhosty opened this issue Mar 12, 2022 · 2 comments
Closed

[Enhancement] Don't crash on errors #25

TheFrenchGhosty opened this issue Mar 12, 2022 · 2 comments

Comments

@TheFrenchGhosty
Copy link

TheFrenchGhosty commented Mar 12, 2022

Currently the scripts crash on errors (eg: Temporary failure in name resolution), it would be nice if it could either retry and/or skip on errors, similarly to youtube-dl/yt-dlp --retries X and --ignore-errors

As a workaround, I currently just run the download on a while loop, but it's not ideal.

Also it "crashes" on CTRL+C

@Emersont1
Copy link
Owner

The errors that it encounters are due to the connection issues between the program and itch.io, adding mechanisms to retry would add bloat and not fix the underlying issue

@TheFrenchGhosty
Copy link
Author

TheFrenchGhosty commented Mar 12, 2022

@Emersont1 I mean, yes, but there's no way to fix the underlying issue, since it's on their side. This is why retrying might be a good idea.

Though I guess if you want to keep the script minimal/KISS, a while loop is enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants