Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module-wide description field validation #451

Closed
Tracked by #327
ba1ciu opened this issue Jan 25, 2023 · 3 comments · Fixed by #470
Closed
Tracked by #327

Module-wide description field validation #451

ba1ciu opened this issue Jan 25, 2023 · 3 comments · Fixed by #470
Assignees
Labels
C:x/plasticcredit Plastic credit component

Comments

@ba1ciu
Copy link
Collaborator

ba1ciu commented Jan 25, 2023

We allow any utf-8 string of length up to 256 characters in description fields.

Implement the check in new utils/validation.go file in a similar manner to how it was done for name validation. For reference, see the name implementation here: #454

@ba1ciu ba1ciu added the C:x/plasticcredit Plastic credit component label Jan 25, 2023
@aljo242
Copy link
Contributor

aljo242 commented Feb 10, 2023

@gjermundgaraba @ba1ciu starting this

@aljo242
Copy link
Contributor

aljo242 commented Feb 10, 2023

@ba1ciu @gjermundgaraba by "alpha numeric" do you mean literally only the characters:

abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ0123456789

I think it might be useful to allow for more characters than this such as punctuation, brackets, etc..

@gjermundgaraba
Copy link
Contributor

@aljo242, yeah you are right, it should be utf-8 string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/plasticcredit Plastic credit component
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants