Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

From docker to node #11

Closed
jactor-rises opened this issue Dec 12, 2019 · 2 comments
Closed

From docker to node #11

jactor-rises opened this issue Dec 12, 2019 · 2 comments
Labels
type: invalid This doesn't seem right

Comments

@jactor-rises
Copy link

jactor-rises commented Dec 12, 2019

Hi

My fork of your repository is rewritten as a node-artifact and do not need any Dockerfile. However, my GitHub workflow fails when using the node-branch (I also tried the master branch with docker). The failure is caused by the folder node_modules being ignored: https://github.com/jactor-rises/add-and-commit/runs/345587672

Is this a suspected failure and has something todo with the default pattern?

@jactor-rises
Copy link
Author

I am also getting a failure on another project using add-and-commit. https://github.com/navikt/bidrag-dokument-dto/commit/7061699a8b6b5d930877b40ef6840941ef492a3c/checks?check_suite_id=355151616 This failure do not occur when using the docker image. I see that the docker image is built from a git image and I would suspect that this image can do more than a normal Linux image.

Is this because of cat <<- EOF > $HOME/.netrc?

@EndBug EndBug added the type: invalid This doesn't seem right label Dec 14, 2019
@EndBug
Copy link
Owner

EndBug commented Dec 14, 2019

Sorry, could you please keep the issues relative to your fork on your fork? (You can mention me there ;))
Anyway:

  1. You should try using the force option, it should add even ignored files.
  2. It may be: the Docker Image uses Alpine (from this container) while your run probably uses Ubuntu. I'm not sure though, you should check the errors and see which part of the code fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants