fix hang on shutdown for fabric due to hanging user threads #2460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JVM initiates shutdown when all non-daemon java threads have terminated. When saving a schematic two threads are created that are never stopped, thus preventing the server for finishing the shutdown. One is the "WorldEdit Task Executor - 0", shich is easily fixed. The second is the TimerThread created by FutureProgressListener. In this patch the timer is made to use a deamon thread instead. If critical scheduled events on this timer persost after a server shutdown is otherwise complete maybe this needs to be changed to an executor service? Otherwise scheduled events may get lost by the server shutting down.
me4502
reviewed
Jan 19, 2024
| @@ -286,6 +287,7 @@ private void onStopServer(MinecraftServer minecraftServer) { | |||
| WorldEdit worldEdit = WorldEdit.getInstance(); | |||
| worldEdit.getSessionManager().unload(); | |||
| WorldEdit.getInstance().getEventBus().post(new PlatformUnreadyEvent(platform)); | |||
| WorldEdit.getInstance().getExecutorService().shutdown(); | |||
There was a problem hiding this comment.
If this is something that must be shut down on Fabric, I feel that we should probably also shut this down on other platforms.
me4502
reviewed
Feb 17, 2024
| @@ -90,6 +90,7 @@ | |||
| import java.util.List; | |||
| import java.util.Optional; | |||
| import java.util.Set; | |||
| import java.util.concurrent.TimeUnit; | |||
There was a problem hiding this comment.
This import also seems to be unnecessary, it should be removed
|
i'll close this for now in favour of #2570 which has been merged. i'm uncertain whether making the Timer a daemon thread could cause some unknown issues, but shutting down the executor is fairly safe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JVM initiates shutdown when all non-daemon java threads have terminated. When saving a schematic two threads are created that are never stopped, thus preventing the server for finishing the shutdown.
One is the "WorldEdit Task Executor - 0", shich is easily fixed.
The second is the TimerThread created by FutureProgressListener. In this patch the timer is made to use a deamon thread instead. If critical scheduled events on this timer persost after a server shutdown is otherwise complete maybe this needs to be changed to an executor service? Otherwise scheduled events may get lost by the server shutting down.
This fixes #2459