Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix hang on shutdown for fabric due to hanging user threads #2460

Closed
wants to merge 1 commit into from

Commits on Jan 17, 2024

  1. fix hang on shutdown for fabric due to hanging user threads

    The JVM initiates shutdown when all non-daemon java threads have
    terminated. When saving a schematic two threads are created that
    are never stopped, thus preventing the server for finishing the
    shutdown.
    
    One is the "WorldEdit Task Executor - 0", shich is easily fixed.
    
    The second is the TimerThread created by FutureProgressListener.
    In this patch the timer is made to use a deamon thread instead. If
    critical scheduled events on this timer persost after a server
    shutdown is otherwise complete maybe this needs to be changed to
    an executor service? Otherwise scheduled events may get lost by
    the server shutting down.
    Peter Svensson committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    22dde65 View commit details
    Browse the repository at this point in the history