Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code highlighting issue in vhdl single quote (') #106

Closed
tyriun opened this issue May 11, 2020 · 11 comments
Closed

code highlighting issue in vhdl single quote (') #106

tyriun opened this issue May 11, 2020 · 11 comments

Comments

@tyriun
Copy link

tyriun commented May 11, 2020

hello
I'm using the plugin with VHDL language, in new version there is some problem with single quote attribute syntax

there is no need to apply highlighting to this kind of syntax, for example error occur in line 2 (Input'length)
plugin look for ending quote pair, but there is no ending pair --> (Input'length') is incorrect

function LeadOneDetector(Input : std_logic_vector) return integer is constant LEN : integer := Input'length; variable Idx : integer range 0 to LEN-1; begin Idx := 0; looop: for i in 0 to LEN-1 loop if Input(i) = '1' then Idx := i; end if; end loop; return Idx; end function LeadOneDetector;

@AndiDittrich
Copy link
Member

can you provide a screenshot/link please ?

which version do you mean (old/new one) ?

@AndiDittrich
Copy link
Member

btw. as i know, single quotes are only valid for single bit literals and not for any kind of labels ?

@tyriun
Copy link
Author

tyriun commented May 11, 2020

new version.
in old version it was correct. you can see the screen sot for the correct form and buggy form of highlighting
look at this link : https://hexalinx.com/programming/fpga-implementation-of-logarithm/?no-cache
or this : https://hexalinx.com/programming/shift-right-and-left-with-barrel-shifter/?no-cache

@tyriun
Copy link
Author

tyriun commented May 11, 2020

Uploading 2020-05-11_18-58-48.jpg…

quotes are only valid for single bit l

we use single quote with no pair for attribute in VHDL

@AndiDittrich
Copy link
Member

ah i see, they're used for predefined attributes

@tyriun
Copy link
Author

tyriun commented May 11, 2020

absolutely, so what can I do? it wasn't the issue in previous version.

@AndiDittrich
Copy link
Member

give me a few seconds to fix it...

@AndiDittrich AndiDittrich transferred this issue from EnlighterJS/Plugin.WordPress May 11, 2020
AndiDittrich added a commit that referenced this issue May 11, 2020
@AndiDittrich
Copy link
Member

fixed within the master branch

image

@tyriun
Copy link
Author

tyriun commented May 11, 2020

Great. thanks for your instant help, but how can update my plugin? do I need to modify it manually? or some thing else?

@AndiDittrich
Copy link
Member

replace the enlighterjs.min.js file with the one from the master branch (dist dir)

@tyriun
Copy link
Author

tyriun commented May 11, 2020

Thank you AndiDittrich, I did it successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants