Amp-a4a: detachedCallback destroy creative frame (ampproject#18344)

* initial commit * handle presubmit error
Enriqe · Nov 28, 2018 · 311452e · 311452e
1 parent bfaff25
commit 311452e
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 0 deletions.
diff --git a/extensions/amp-a4a/0.1/amp-a4a.js b/extensions/amp-a4a/0.1/amp-a4a.js
@@ -1084,6 +1084,12 @@ export class AmpA4A extends AMP.BaseElement {
     this.postAdResponseExperimentFeatures = {};
   }
 
+  /** @override */
+  detachedCallback() {
+    super.detachedCallback();
+    this.destroyFrame(true);
+  }
+
   /**
    * Attempts to remove the current frame and free any associated resources.
    * This function will no-op if this ad slot is currently in the process of

diff --git a/extensions/amp-a4a/0.1/test/test-amp-a4a.js b/extensions/amp-a4a/0.1/test/test-amp-a4a.js
@@ -410,6 +410,18 @@ describe('amp-a4a', () => {
       });
     });
 
+    it('detachedCallback should destroy FIE and detach frame', () => {
+      const fieDestroySpy =
+          sandbox./*OK*/spy(FriendlyIframeEmbed.prototype, 'destroy');
+      a4a.buildCallback();
+      a4a.onLayoutMeasure();
+      return a4a.layoutCallback().then(() => {
+        a4a.detachedCallback();
+        expect(fieDestroySpy).to.be.called;
+        expect(a4aElement.querySelector('iframe')).to.not.be.ok;
+      });
+    });
+
     it('for A4A FIE should wait for initial layout', () => {
       let iniLoadResolver;
       const iniLoadPromise = new Promise(resolve => {