Amp-a4a: detachedCallback destroy creative frame #18344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
approved these changes
Sep 25, 2018
| @@ -1084,6 +1084,12 @@ export class AmpA4A extends AMP.BaseElement { | |||
| this.postAdResponseExperimentFeatures = {}; | |||
| } | |||
|
|
|||
| /** @override */ | |||
| detachedCallback() { | |||
| super.detachedCallback(); | |||
There was a problem hiding this comment.
Nit: no need to call super.
There was a problem hiding this comment.
Figured it can't hurt and good to have should super do something some day....
This was referenced Sep 25, 2018
torch2424
pushed a commit
to torch2424/amphtml
that referenced
this pull request
Oct 10, 2018
* initial commit * handle presubmit error
Enriqe
pushed a commit
to Enriqe/amphtml
that referenced
this pull request
Nov 28, 2018
* initial commit * handle presubmit error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address issue where amp-ad extending amp-a4a- within amp-sticky-ad does not destroy the FIE or remove the frame when a user collapses the sticky.
Fixes #18272.