Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix read-only warning when creating GO data #625

Merged

Conversation

nuno-agostinho
Copy link
Contributor

Fixes #622

May be related with Perl version used. Perl 5.34 returns the following warning: WARNING: Failed to instantiate plugin GO: Modification of a read-only value attempted at /home/meryem/.vep/Plugins/GO.pm line 327.

To avoid this issue, simply get a slice of @$row instead of using splice() that tries to modify the original array.

Test

Try to create GO plugin data with: ./vep --id rs699 --database --plugin GO

@nakib103 nakib103 self-requested a review August 17, 2023 12:53
@nakib103 nakib103 self-assigned this Aug 17, 2023
Copy link
Contributor

@nakib103 nakib103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Nuno, it fixes the issue.

The error - Modification of a read-only value attempted is introduced in splice function in perl 5.28.0.

It says -

splice now throws an exception ("Modification of a read-only value attempted") when modifying a read-only array. Until now it had been silently modifying the array. The new behaviour is consistent with the behaviour of push and unshift. [perl #131000]

under https://perldoc.perl.org/5.28.0/perldelta#Selected-Bug-Fixes

@nakib103 nakib103 merged commit c80c195 into Ensembl:postreleasefix/111 Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants