-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return structural variants by ID in Variation/VEP endpoints #603
Conversation
The documentation specifies which type of ID is supported: http://rest.ensembl.org/documentation/info/vep_id_get |
Hey @dglemos, I updated documentation on the following pages to include structural variant ID examples: |
Hi @nuno-agostinho, please could I check if this is for Release 111 or 112? Thanks! |
Hi @nwillhoft, this is for 112, so no need to rush. Still waiting for an approval from @dglemos. Thanks for asking! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving PR based on code review carried out by Variation team.
Description
ENSVAR-5793: Return structural variants (SVs) by their ID when using Variation/VEP endpoints.
The information displayed for SVs is based on their Ensembl Variation page: for instance, esv1815690
Requires Ensembl/ensembl-variation#1029.
Use case
Users request that these endpoints return SVs (e.g.,
esv1815690
). Currently, they only return non-SVs (e.g.,rs699
).Possible Drawbacks
If all IDs are non-SVs, the code will take the same time as before; otherwise, the code looks for the mismatched IDs in the SV table.
Also, some SVs may hit the memory limit, such as in the case of
nsv3901821
, and return an error message:ERROR: Cannot allocate memory
.Testing
Unit tests added (but failing because they require Ensembl/ensembl-variation#1029).
Some examples
Documentation changes
Check the following documentation updates in my sandbox:
Changelog
[/variation/:species/id] Return structural variants by their ID
[/variation/:species] Return structural variants by their ID
[/vep/:species/id] Return structural variants by their ID
[/vep/:species] Return structural variants by their ID