Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MaveDB plugin data creation #1035

Merged
merged 3 commits into from
Sep 5, 2023
Merged

Fix MaveDB plugin data creation #1035

merged 3 commits into from
Sep 5, 2023

Conversation

nuno-agostinho
Copy link
Contributor

@nuno-agostinho nuno-agostinho commented Sep 1, 2023 •
edited

ENSVAR-5960: Ensure MaveDB VEP plugin works with regulatory data

  • Fix start position for all genomic HGVS variants (zero-index position is now one-index position to conform with protein HGVS)
  • Update URL for MaveDB REST endpoint (previous one is now invalid)

Note: The path to the updated plugin data is mentioned in ENSVAR-5960 and can be tested with Ensembl/VEP_plugins#628.

@nuno-agostinho nuno-agostinho changed the title Fix MaveDB data creation Fix MaveDB plugin data creation Sep 1, 2023
@nuno-agostinho nuno-agostinho mentioned this pull request Sep 4, 2023
Merged
nakib103
nakib103 approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@nakib103 nakib103 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOTM!~

@nakib103 nakib103 merged commit 9db7f45 into Ensembl:postreleasefix/111 Sep 5, 2023
1 check passed
@nuno-agostinho nuno-agostinho deleted the fix/mavedb-data branch September 6, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nakib103 nakib103 nakib103 approved these changes

Assignees

@nakib103 nakib103

Labels
e111
Projects
None yet
Milestone
No milestone
2 participants
@nuno-agostinho @nakib103