Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new store #4

Closed
srokatonie opened this issue Dec 10, 2018 · 7 comments
Closed

Add new store #4

srokatonie opened this issue Dec 10, 2018 · 7 comments
Assignees

Comments

@srokatonie
Copy link

Hi, I am looking to add store in Ireland. Can you tell how to find a store code?

I should add this to ./data/buCodes.csv and ./data/stores.json ?

@Ephigenia
Copy link
Owner

Hi @srokatonie thanks for joining. If there are new stores they should be added to the ./data/stores.json file. The CSV file next to it is just a legacy file which I created using google docs back then. It will be removed in one of the next versions.

Also please feel free to create a pull request with the new store in Ireland. You can test if your additions work by calling npm start stores -- EI which should list them in the output.

@srokatonie
Copy link
Author

Hi @Ephigenia,
How do you find Ikea store's buCode? Where do you get it from?

PS. I have an issue with listing stores from ST, ES (and possibly more) - blank result. I will have a look when pulling the repo and adding IE.

@Ephigenia
Copy link
Owner

Ephigenia commented Dec 11, 2018

@srokatonie please provide your changes as a pull request then I can also have a look at it and give better feedback.

Back in the days, the BU codes were clearly visible in the source code of the store location dropdown on a product’s detail page. Now it seems to be a bit more difficult by I think Belfast is buCode 038.

@srokatonie
Copy link
Author

@Ephigenia I am actually looking for the Dublin's store code. I will contact their support.

@Ephigenia
Copy link
Owner

@srokatonie there’s no need for asking them. 038 is the buCode for the Dublin store. I’m just preparing a pull request myself cause Ireland is not listed anywhere in the code and must be added in various locations.

@Ephigenia
Copy link
Owner

Ephigenia commented Dec 12, 2018

I noticed that Ireland is a special case as some other countries too. They use a different endpoint of the iows API (https://www.ikea.com/ie/en/retail/iows/stores/038/item/SPR,29932181) and must be requested and parsed differently. There needs to be more work done to support that. I’m sorry but at this time the integration is not easily done.

@srokatonie
Copy link
Author

@Ephigenia I'd be happy to contribute, I need this for one of my projects.

@Ephigenia Ephigenia self-assigned this Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants