This repository has been archived by the owner on Mar 1, 2024. It is now read-only.
Properly inject new params into SDP to get stereo back on Chrome #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Belchy06
approved these changes
Jul 26, 2023
Belchy06
approved these changes
Jul 26, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Jul 27, 2023
(cherry picked from commit 1947760)
github-actions bot
pushed a commit
that referenced
this pull request
Jul 27, 2023
(cherry picked from commit 1947760)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Belchy06
pushed a commit
that referenced
this pull request
Jul 27, 2023
Belchy06
pushed a commit
that referenced
this pull request
Jul 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant components:
Problem statement:
Chrome suddenly stopped doing stereo output the other day...
Solution
It turns out we were never actually modifying the SDP string because the return values for
replacewere being thrown away instead of being applied tomungedSDPwhich had itself been declaredconstfor some reason anyway.Documentation
N/A
Test Plan and Compatibility
I simply recompiled and checked out the infra in Chrome, noting that stereo has indeed returned. For good measure, I also checked the applied SDP configuration, noting that it now actually reflects the changes we wanted.