Skip to content
This repository has been archived by the owner on Mar 1, 2024. It is now read-only.

Properly inject new params into SDP to get stereo back on Chrome #332

Merged
merged 2 commits into from
Jul 27, 2023
Merged

Properly inject new params into SDP to get stereo back on Chrome #332

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f472d6a
Properly inject new params into SDP to get stereo back on Chrome
StomyPX Jul 26, 2023
8c4dff7
Forgot to remove a sneaky little plus sign
StomyPX Jul 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 3 additions & 6 deletions Frontend/library/src/PeerConnectionController/PeerConnectionController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,16 +207,13 @@ export class PeerConnectionController {
* @returns A modified Session Descriptor
*/
mungeSDP(sdp: string, useMic: boolean) {
const mungedSDP = sdp;
mungedSDP.replace(
let mungedSDP = sdp.replace(
/(a=fmtp:\d+ .*level-asymmetry-allowed=.*)\r\n/gm,
'$1;x-google-start-bitrate=10000;x-google-max-bitrate=100000\r\n'
);

let audioSDP = '';

// set max bitrate to highest bitrate Opus supports
audioSDP += 'maxaveragebitrate=510000;';
let audioSDP = 'maxaveragebitrate=510000;';

if (useMic) {
// set the max capture rate to 48khz (so we can send high quality audio from mic)
Expand All @@ -232,7 +229,7 @@ export class PeerConnectionController {
audioSDP += 'useinbandfec=1';

// We use the line 'useinbandfec=1' (which Opus uses) to set our Opus specific audio parameters.
mungedSDP.replace('useinbandfec=1', audioSDP);
mungedSDP = mungedSDP.replace('useinbandfec=1', audioSDP);

return mungedSDP;
}
Expand Down