Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #19, update promoters metadata #78

Merged
merged 6 commits into from
Aug 18, 2020
Merged

Conversation

lacava
Copy link
Collaborator

@lacava lacava commented Jul 31, 2020

this (unfinished!) PR removes the promoters dataset because it is a duplicate of molecular_biology_promoters (issue #19). I also began to add metadata to molecular_biology_promoters, but I have not yet gotten the source data to exactly match our version. It also appears that the class labels are reversed which we might want to fix.

here is a colab notebook where i'm working on source verification

@trangdata trangdata changed the base branch from PMLB2.0 to master August 16, 2020 01:50
@trangdata
Copy link
Collaborator

The UCI link gives the pre-processed data. I think it's more straightforward if we just cite this link from openml.

I can't save my changes on your colab notebook, so I made a copy to verify they're the same here.

We also need to remove the instance column because it's a row identifier, as mentioned in #19 (see profiling report). I can help with that.

@weixuanfu
Copy link
Contributor

I found instance feature in the metadata but cannot find it on the dataset.

@trangdata trangdata merged commit 223569e into master Aug 18, 2020
@trangdata trangdata deleted the update_promoters branch August 18, 2020 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants