code cleanup #22
Merged
code cleanup #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for all these PRs. This is great. Yes, I think we should improve the docstrings. Please file an issue for that so we don't forget. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaning up some style issues.
Question: I didn't want to make any changes to the docstrings because this is a personal taste thing, and I am not sure what you think about it, but what about using standard Python docstrings? Also, the docstrings are not very informative, e.g., if someone uses
help(TPOT), there wouldn't be much information on the attributes and methods. I'd recommend to change that, also with respect to a future auto-generated API documentation.