Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dict comprehensions, min(max()), or and more #98

Closed
wants to merge 2 commits into from

Conversation

cclauss
Copy link

@cclauss cclauss commented Feb 28, 2016

[please review the contribution guidelines prior to submitting your pull request. go ahead and delete this line if you've already reviewed said guidelines.]

What does this PR do?

Where should the reviewer start?

How should this PR be tested?

Any background context you want to provide?

What are the relevant issues?

[you can link directly to issues by entering # then the number of the issue, for example, #3 links to issue 3]

Screenshots (if appropriate)

Questions:

  • Do the docs need to be updated?
  • Does this PR add new (Python) dependencies?

self.scoring_function = self._balanced_accuracy
else:
self.scoring_function = scoring_function
self.scoring_function = scoring_function or self._balanced_accuracy
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure about changes like this because it makes the code less explicit and harder to read. In fact, I'm not even sure if this line works? I'm assuming it does if you submitted the change.

@rhiever
Copy link
Contributor

rhiever commented Feb 28, 2016

Thank you again for these suggestions! I do like some of them (as noted in the line-by-line comments), but I err toward a longer and more explicit way of writing code to make it easier to read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants