Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Registry, rework how Space is passed to algorithms #833

Merged
merged 126 commits into from
Mar 30, 2022
Merged

Add Registry, rework how Space is passed to algorithms #833

merged 126 commits into from
Mar 30, 2022

Conversation

lebrice
Copy link
Collaborator

@lebrice lebrice commented Mar 16, 2022 •
edited

Description

Describe what is the purpose of this pull request and why it should be integrated to the repository.
When your changes modify the current behavior, explain why your solution is better.

Fixes #802

Changes

Algorithms now receive the space they will actual work with in their constructor.

Checklist

Tests

  • I added corresponding tests for bug fixes and new features. If possible, the tests fail without the changes
  • All new and existing tests are passing ($ tox -e py38; replace 38 by your Python version if necessary)

Documentation

  • I have updated the relevant documentation related to my changes

Quality

  • I have read the CONTRIBUTING doc
  • My commits messages follow this format
  • My code follows the style guidelines ($ tox -e lint)

@lebrice
Temporary copy of ideas file from meeting
08b7b5c 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Initial implementation of Registry classes
ef16a91 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Move registry.py to src/orion/algo
4f49b43 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Adapt BaseAlgorithm to use Registry
24133c2 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Adapt tests in algo/test_base.py
647da59 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Refactor SpaceTransformAlgoWrapper + Typing
61f0402 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Make state_dict properties instead of methods
e432992 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Adapt Random.suggest() for registry
998cd29 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Change how algo (and wrapper) are created
96b3085 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Fix bug with has_observed / has_suggested
15bbb6f 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Update how algo is created in algo tests
6d52642 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Fix bug with state_dict by adding deepcopy's
3a8b19a 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Start adapting Hyperband: Add type hints
652eb1f 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Fix typo in BaseAlgorithm
972d0de 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
[Hyperband] Reorganize imports, add more typehints
c1a5d07 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Add fixes for special cases in algo wrapper
a34518e 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Fix bug in BaseAlgo and PrimaryAlgo n_observed
e2a3cad 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Fix all tests with Hyperband!
1df44be 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Add type hints to ASHA
4b4c979 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Make SpaceTransformAlgoWrapper Generic + get_id
6379fe6 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Add type hints to tests for asha and hyperband
3782e7f 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Mist isort + black changes
c8d38d2 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Add type hints and adapt evolution_es.py
4d224c5 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Add type hints to test_evolution_es.py & RungDict
8dea2c5 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Fix more type-checking errors in test_hyperband.py
7a8c876 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Add type hints to tpe & begin fixing tests
3029a85 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Skip old tests that were ignored before
68f14e3 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Begin Adapting PBT + tests
4a334b0 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Black + isort
84aa1ec 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
[optional] Add type hints in utils/tree.py
d9047e8 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Remove duplicated testing code for create_algo
f72e3b7 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Correct docstring and simplify fidelity_index
5b48ead 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Refactor BaseAlgorithm & Hyperband is_done
1aedf7b 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Add some unit tests for Registry, RegistryMapping
2c1d4ba 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Adding new tests in test_primary_algo.py
031c98c 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Revert change to random.py
15ffe06 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Prevent overwriting older trials in register
86544b7 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Fix bug in is_done for algos with fidelity
2455f89 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Debugging GridSearch failure (space cardinality)
5686d6d 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Reuse BaseAlgorithm.is_done logic in Wrapper
af5d93c 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Revert GridSearch.is_done change, move variables
dfbfd41 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice lebrice mentioned this pull request Mar 29, 2022
Merged
6 tasks
@lebrice
Fix bug in Hyperband.is_done
c28a1cf 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Revert hard-coded value change in test_suggest_new
eb36a9d 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Improve/fix test conditions in TestRegistration
31896a8 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@bouthilx bouthilx mentioned this pull request Mar 29, 2022
Open
@lebrice
SpaceTransformAlgoWrapper subclass BaseAlgorithm
02a9e15 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Fix issue with GridSearch and TransformedSpace
4a9404a 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Fix bug with new argument ordering of wrapper
53d9317 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Merge branch 'develop' into registry
3ced427
@lebrice
Adjust IO thresholds in test_io
e26961d 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Remove has_observed_max_trials
7e27b2d 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Revert "Remove has_observed_max_trials"
ccae1ac 
This reverts commit 7e27b2d.
@lebrice
has_observed_max_trials ->has_completed_max_trials
ce71026 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@lebrice
Dont register trials externally, update docstring
3c77187 
Signed-off-by: Fabrice Normandin <fabrice.normandin@gmail.com>
bouthilx
bouthilx approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@bouthilx bouthilx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this great PR!

@bouthilx bouthilx mentioned this pull request Mar 30, 2022
Open
@lebrice lebrice merged commit 7fbd124 into Epistimio:develop Mar 30, 2022
@bouthilx bouthilx mentioned this pull request Apr 1, 2022
Merged
@bouthilx bouthilx added the enhancement Improves a feature or non-functional aspects (e.g., optimization, prettify, technical debt) label May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bouthilx bouthilx bouthilx approved these changes

Assignees
No one assigned
Labels
enhancement Improves a feature or non-functional aspects (e.g., optimization, prettify, technical debt)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rework how transformed space is passed to algorithms
2 participants
@lebrice @bouthilx