Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ax Optimizer #866

Merged
merged 13 commits into from
May 30, 2022
Merged

Add Ax Optimizer #866

merged 13 commits into from
May 30, 2022

Conversation

satyaog
Copy link
Contributor

@satyaog satyaog commented Mar 29, 2022 •
edited
Loading

resolves #838

@satyaog satyaog changed the base branch from master to develop March 29, 2022 19:54
@satyaog satyaog force-pushed the feature/ax branch 2 times, most recently from 01c1f02 to 6f7a627 Compare March 29, 2022 20:03
@satyaog
Copy link
Contributor Author

satyaog commented Mar 29, 2022

Not sure what this error means (from tox -e docs) as line 81 is actually a comment line?

sphinx.errors.SphinxWarning: /Users/satyaortiz-gagne/travail/mila/CODE/orion/src/orion/algo/axoptimizer.py:docstring of orion.algo.axoptimizer.AxOptimizer:81:<autosummary>:1:Inline interpreted text or phrase reference start-string without end-string.

https://github.com/Epistimio/orion/pull/866/files#diff-be664fe472a4fc6c945dfbc95b68478ca42bbd9f766bf1fc44d6f53debc27a59R81

lebrice
lebrice reviewed Mar 29, 2022
View reviewed changes
src/orion/algo/axoptimizer.py Show resolved Hide resolved
src/orion/algo/axoptimizer.py Outdated Show resolved Hide resolved
src/orion/algo/axoptimizer.py Outdated Show resolved Hide resolved
tests/unittests/algo/test_axoptimizer.py Outdated

def test_configuration_fail(self):
"""Test that Ax configuration is valid"""
with pytest.raises(AssertionError) as exc_info:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the AssertionError in axoptimizer.py? or in self.create_algo ?

Copy link
Contributor Author

@satyaog satyaog Mar 30, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None actually, it comes from Ax's client.create_experiment() when it checks for the string format of outcomes constraints

@bouthilx bouthilx added the feature Introduces a new feature label Mar 31, 2022
satyaog and others added 6 commits April 1, 2022 16:14
@satyaog
Add Ax Optimizer
c5af5b1
@satyaog
Small docs edits
92124a8
@satyaog @lebrice
Apply suggestions from code review
417c8a1 
Co-authored-by: Fabrice Normandin <fabrice.normandin@gmail.com>
@satyaog @bouthilx
Apply suggestions from code review
916d785 
Co-authored-by: Xavier Bouthillier <xavier.bouthillier@gmail.com>
@satyaog
Fix Ax docs
d6522e8
@satyaog
Fix Ax tests
ffaae0f
@bouthilx
Merge branch 'develop' into feature/ax
723c09e
@bouthilx
Merge branch 'develop' into feature/ax
2516a82
@bouthilx
Change ordering of algos in doc
6b7e202
@bouthilx
Stop turning sphinx warnings into errors
9b85bb2 
Why:

With new sphinx version having non-escaped % raises warnings but it
gives no indication to where these % are so that we can escape them.
Stop turning sphinx warnings into errors until we have an automated way
of fixing this...
@bouthilx
Adjust tests to new test-suite format
9639b4c
@bouthilx
Move Ax tests to long test jobs
c3725e3
@bouthilx
Removed useless json file
bf64ac8
@bouthilx bouthilx merged commit f4026d6 into Epistimio:develop May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lebrice lebrice lebrice left review comments

@bouthilx bouthilx bouthilx left review comments

Assignees
No one assigned
Labels
feature Introduces a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate orion.algo.ax
3 participants
@satyaog @bouthilx @lebrice