Fixed App_Callback() to be interrupt safe for asynchronous TX/RX streams... #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErichStyger
pushed a commit
that referenced
this pull request
Oct 24, 2014
Fixed App_Callback() to be interrupt safe for asynchronous TX/RX streams...
|
Many thanks for that contribution. I have not thought about this being an issue, and it seems that I have not seen it on my side. Anyway, good fix, thank you! |
|
Thanks, this could solve the issue I'm experiencing regarding incoming CDC messages not being acknowledged by the MCU (missing USB ACK byte). I'll let you guys know. Carlos |
|
It works! Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the original code was written for a sequential TX => RX => TX... chain. On the other hand, if the MCU (CDC_DEVICE) and host communicate with asynchronous TX/RX streams, the RX endpoint FSM on the MCU can become corrupted. This corruption stalls the incoming RX stream. The changes resolve this issue.