-
-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Kingbase support for efcore 80 #2365
Conversation
@@ -395,6 +398,20 @@ public static List<NuGetPackage> GetNeededPackages(DatabaseType databaseType, bo | |||
}); | |||
} | |||
|
|||
if (databaseType == DatabaseType.KingBase) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be conditional based on codeGenerationMode
@@ -42,6 +42,8 @@ | |||
<PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer.NetTopologySuite" Version="8.0.5" /> | |||
<PackageReference Include="Npgsql.EntityFrameworkCore.PostgreSQL.NodaTime" Version="8.0.4" /> | |||
<PackageReference Include="Npgsql.EntityFrameworkCore.PostgreSQL.NetTopologySuite" Version="8.0.4" /> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Remove empty line
{ | ||
"DotNetCore.EntityFrameworkCore.KingbaseES", | ||
new List<string> { "kingbase" } | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add trailing comma
@hatzhang I am going to close this for now, we can re-open if the KingBase provider gets fixed |
No description provided.