New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xdoctest is breaking with TypeError: getfixtureinfo() got an unexpected keyword argument 'funcargs'
#151
Comments
I'm also seeing in this in my CI builds. Are there any easy ways to resolve this via version pinning? |
Looks as though the changes are likely due to |
### What kind of change does this PR introduce? * Pins `pytest` below v8.0 due to breakage with `xdoctest` * Now using the `bump-my-version` Conda-forge package ### Does this PR introduce a breaking change? No. ### Other information: Erotemic/xdoctest#151
I have a patch in #150 that should handle pytest 8.x as well as previous versions. Will merge and release a new branch once CI passes. For now ensure pytest is |
I'm having issues getting the dashboards to work on windows. I've verified that it only happens with pytest 8.0 on windows other platforms seem fine. https://github.com/Erotemic/xdoctest/actions/runs/7704989009/job/20998236140 It's just 2 tests that are failing, both having to do with running the pytest CLI:
and pytest prints:
So it's not recognizing that the directory has a python file with a doctest in it. I'm wondering if the
which seems fine. For the other test, which calls pytest directly on a file, it gives this output and error:
Which indicates to me pytest itself might be having a hard time resolving this short path. If anyone has any ideas I could use some help on this. |
* chore(deps): bump furo from 2023.9.10 to 2024.1.29 Bumps [furo](https://github.com/pradyunsg/furo) from 2023.9.10 to 2024.1.29. - [Release notes](https://github.com/pradyunsg/furo/releases) - [Changelog](https://github.com/pradyunsg/furo/blob/main/docs/changelog.md) - [Commits](pradyunsg/furo@2023.09.10...2024.01.29) --- updated-dependencies: - dependency-name: furo dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Run `poetry lock` * Fix env var tests * Revert pytest bump Erotemic/xdoctest#151 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Edgar Ramírez-Mondragón <edgarrm358@gmail.com>
I believe that I've been able to resolve the issue. It seems like ensuring that the tests use long paths intead of short paths resolves the issue. I made an issue in pytest to make them aware of the problem here: pytest-dev/pytest#11895 But as far as xdoctest is concerned, everything should be good to go. I'm going to merge and make a release and the new version should fix most pytest 8.0 issues (unless you are using short paths on windows). |
new release is live |
Python version: all
xdoctest
throws an error in CI just at setup. This same CI pipeline was working fine the last week and no changes have been made since then. The error seems to be originating from withinxdoctest
.Command used:
python -m pytest -ra --cov=vector --xdoctest --ignore tests/test_notebooks.py .
See the failing logs for the complete error.
Stacktrace for a single doctest error:
The text was updated successfully, but these errors were encountered: