Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpp] Animations with IK Constraints not behaving as expected #1860

Closed
cp4117 opened this issue Mar 12, 2021 · 1 comment
Closed

[cpp] Animations with IK Constraints not behaving as expected #1860

cp4117 opened this issue Mar 12, 2021 · 1 comment
Assignees
Milestone

Comments

@cp4117
Copy link

cp4117 commented Mar 12, 2021

I've noticed an issue in IkConstraint.cpp which leads to animations that use such constraints to not animate correctly.

Going through the json implementation I noticed the label break_outer is in a different location. Moving this goto label from line 240 to 176 to line up with the json implementation appears to fix the issue.

@badlogic badlogic self-assigned this Apr 29, 2021
@badlogic badlogic added this to the v4.0 milestone Jun 10, 2021
@badlogic
Copy link
Collaborator

I've tried to reproduce this with our stretchyman example, which triggers the goto break_outer. It behaves as expected and in line with the reference implementation. Happy to reopen if you can supply me with an animation that does not work for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants