[spine-unity] Fix for the issue [2346] causing canvasRenderers and submeshGraphics to get unsynced

[sandolkakos]

Fix for the issue 2346 causing canvasRenderers and submeshGraphics to get unsynced and throwing null exception reference at:

spine-runtimes/spine-unity/Assets/Spine/Runtime/spine-unity/Components/SkeletonGraphic.cs

Line 1055 in 3b8069f

SkeletonSubmeshGraphic submeshGraphic = submeshGraphics[i];

[HaraldCsaszar]

@sandolkakos Thanks for the pull request! Unfortunately we have to decline it this time since SyncSubmeshGraphicsWithCanvasRenderers is not intended to be called every frame, as we want to avoid calling canvasRenderer.GetComponent<SkeletonSubmeshGraphic>(); that frequently.

It would be great to know why canvasRenderers and submeshGraphics can get out of sync, then we could provide a more cost-efficient bugfix.

[sandolkakos]

@sandolkakos Thanks for the pull request! Unfortunately we have to decline it this time since SyncSubmeshGraphicsWithCanvasRenderers is not intended to be called every frame, as we want to avoid calling canvasRenderer.GetComponent<SkeletonSubmeshGraphic>(); that frequently.

It would be great to know why canvasRenderers and submeshGraphics can get out of sync, then we could provide a more cost-efficient bugfix.

Ohh I see. Fair enough, I haven't checked it was called from Update! 😅
I will try to find a time on the next weeks to see if I can find the reason for both arrays getting out of sync in our project.

[HaraldCsaszar]

@sandolkakos Thanks very much for your understanding and for all your efforts! :)