Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify block interface to support DA #705

Closed
jbearer opened this issue Nov 8, 2022 · 2 comments · Fixed by #818
Closed

Modify block interface to support DA #705

jbearer opened this issue Nov 8, 2022 · 2 comments · Fixed by #818
Assignees
Labels

Comments

@jbearer
Copy link
Member

jbearer commented Nov 8, 2022

  • Type for full block with data
  • Type for block commitment
  • Interface to add transactions to the full block
  • Interface to get a commitment from full block
  • Change all replica logic to work with the commitment, not the full block
@nmccarty
Copy link
Contributor

nmccarty commented Nov 14, 2022

  • Type for full block with data
    Using the old Block
  • Type for block commitment
    Using a new type wrapper BlockCommitment
  • Interface to add transactions to the full block
    Already exists on old block type
  • Interface to get a commitment from full block
    Added block_commit method to Block
  • Change all replica logic to work with the commitment, not the full block

@nmccarty
Copy link
Contributor

We now have a set of wrapper types in da.rs that wrap an existing block type into a family of types that only work on the commitments to those blocks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants