Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: Network requests should be mocked #86

Closed
rolson opened this issue Jul 13, 2022 · 4 comments
Closed

Tests: Network requests should be mocked #86

rolson opened this issue Jul 13, 2022 · 4 comments

Comments

@rolson
Copy link
Contributor

rolson commented Jul 13, 2022

The tests for the toolkit are running very slowly. Even with some test disabled, they are taking me over 500 seconds to run:

Test Suite 'ArcGISToolkitTests.xctest' failed at 2022-07-13 15:18:30.653.
	 Executed 37 tests, with 1 failure (1 unexpected) in 507.281 (507.302) seconds
Test Suite 'Selected tests' failed at 2022-07-13 15:18:30.654.
	 Executed 37 tests, with 1 failure (1 unexpected) in 507.281 (507.303) seconds

Ideally these tests would take less than a few seconds as they are unit tests. The fact that they take so long will discourage developers from running them and the tests will fall into disrepair.

@dfeinzimer
Copy link
Collaborator

@rolson, Mockingbird is used on the SDK, correct? Would we be able to use it in the toolkit as well?

@rolson
Copy link
Contributor Author

rolson commented Aug 8, 2022

As it is, no, because it's not public.

@dfeinzimer
Copy link
Collaborator

@rolson Would it be okay if I close this out as a duplicate of #6?

@rolson
Copy link
Contributor Author

rolson commented Nov 4, 2022

Oh sure, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants