Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

feat(flow-item,panel): Add an onscroll event for FlowItem and Panel #842

Merged
merged 3 commits into from
Feb 27, 2020
Merged

feat(flow-item,panel): Add an onscroll event for FlowItem and Panel #842

merged 3 commits into from
Feb 27, 2020

Conversation

driskull
Copy link
Member

Related Issue: #841

Summary

Enhancement: calcite-flow-item needs an onscroll event

  • Update demos
  • Add scroll events to panel and flow-item

@driskull driskull added enhancement New feature request for an existing component 1 - assigned p - low labels Feb 20, 2020
@driskull driskull added this to the Ice King milestone Feb 20, 2020
@driskull driskull requested a review from a team as a code owner February 20, 2020 18:40
@driskull driskull self-assigned this Feb 20, 2020
@driskull driskull changed the title Enhancement: calcite-flow-item needs an onscroll event feat(flow-item,panel): Add an onscroll event for FlowItem and Panel Feb 20, 2020
jcfranco
jcfranco approved these changes Feb 27, 2020
View reviewed changes
Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you add an automated test for this? 🙇

@driskull driskull mentioned this pull request Feb 27, 2020
Closed
@driskull
Copy link
Member Author

Added issue for test.

@driskull driskull merged commit 356e399 into master Feb 27, 2020
@driskull driskull deleted the dris0000/scroll-events-panel-flow-item branch February 27, 2020 22:16
@driskull driskull mentioned this pull request Aug 4, 2020
Merged
driskull added a commit that referenced this pull request Aug 6, 2020
@driskull
feat(panel): Add tooling to test onscroll event for FlowItem and Panel …
ddb2f1f 
…#842 #859 (#1050)

* #859 add test for scrolling

* fix test.

* cleanup
@kat10140 kat10140 mentioned this pull request Sep 10, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jcfranco jcfranco jcfranco approved these changes

Assignees

@driskull driskull

Labels
1 - assigned enhancement New feature request for an existing component p - low
Projects
None yet
Milestone
Ice King
Development

Successfully merging this pull request may close these issues.
2 participants
@driskull @jcfranco