Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

fix(action, flow, pick-list, sortable-list, tip-manager, value-list): react to DOM mutations earlier to avoid stagnant renders #920

Conversation

jcfranco
Copy link
Member

@jcfranco jcfranco commented Apr 7, 2020

Related Issue: #919

Summary

This addresses an issue that arose when components were used in another VDOM library (maquette) and children were added after connectedCallback (MutationObserver is initialized), but before componentWillLoad (MutationObserver starts observing), preventing some initialization logic from kicking in.

cc @AdelheidF

… react to DOM mutations earlier to avoid stagnant renders
@jcfranco jcfranco added bug Something isn't working p - high labels Apr 7, 2020
@jcfranco jcfranco added this to the KOO (King of Ooo) milestone Apr 7, 2020
@jcfranco jcfranco requested a review from driskull April 7, 2020 15:42
@jcfranco jcfranco requested a review from a team as a code owner April 7, 2020 15:42
@jcfranco jcfranco self-assigned this Apr 7, 2020
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jcfranco jcfranco merged commit 700d9f8 into master Apr 7, 2020
@jcfranco jcfranco deleted the jcfranco/919-update-mutation-observers-to-observe-after-initialization branch April 7, 2020 18:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working p - high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants