Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Popover - Allow flipPlacements to allow logical placements such as leading and trailing #8825

Closed
2 of 6 tasks
jmanke opened this issue Feb 23, 2024 · 2 comments
Closed
2 of 6 tasks

Popover - Allow flipPlacements to allow logical placements such as leading and trailing #8825

jmanke opened this issue Feb 23, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Dashboards Issues logged by ArcGIS Dashboards team members. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive
Milestone
2024-06-25 - Jun ...

Comments

@jmanke
Copy link

jmanke commented Feb 23, 2024 •
edited
Loading

Check existing issues

Description

In the calcite-popover, I would expect the flipPlacements to accept the same placement types as placement, but this doesn't seem to be the case. I wanted to use leading and trailing placements in flipPlacements, but it's not supported.

flipPlacements placement
Screenshot 2024-02-23 at 8 01 25 AM Screenshot 2024-02-23 at 8 02 46 AM

Acceptance Criteria

Allow flipPlacements to use logical placements (like in placement) to support leading and trailing variations.

Relevant Info

See codepen for example of leading and trailing not supported.

Which Component

calcite-popover

Example Use Case

I want my flipPlacements to be rtl aware for left/right placements - for example, I'd like the placement to fallback to the left in ltr mode, and to the right when in rtl mode.

Priority impact

p4 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Dashboards
@jmanke jmanke added 0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels Feb 23, 2024
@github-actions github-actions bot added impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive ArcGIS Dashboards Issues logged by ArcGIS Dashboards team members. calcite-components Issues specific to the @esri/calcite-components package. labels Feb 23, 2024
driskull added a commit that referenced this issue Jun 1, 2024
@driskull
feat(action-menu, combobox, dropdown, input-date-picker, popover): al…
7f881ca 
…low logical placements for flipPlacements property. #8825
@driskull driskull mentioned this issue Jun 1, 2024
Merged
driskull added a commit that referenced this issue Jun 6, 2024
@driskull
feat(action-menu, combobox, dropdown, input-date-picker, popover): al…
45aabaa 
…low logical placements for flipPlacements property. #8825 (#9490)

**Related Issue:** #8825

## Summary

- Allow logical placements in the `flipPlacements` array property.
- This allows placement options such as `leading`, `leading-start`,
`trailing`, etc. Not any `auto` options.
- Updates tests
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 0 - new New issues that need assignment. labels Jun 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 6, 2024

Installed and assigned for verification.

@geospatialem geospatialem added this to the 2024-06-25 - Jun Release milestone Jun 6, 2024
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed needs triage Planning workflow - pending design/dev review. 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jun 6, 2024
@geospatialem
Copy link
Member

Verified in 2.10.0-next.0:

verify

benelan added a commit that referenced this issue Jun 10, 2024
@benelan
Merge remote-tracking branch 'origin/main' into benelan/new-release-w…
7bfd4f2 
…orkflow

* origin/main: (26 commits)
  revert: refactor: add simpler `componentFocusable` util (deprecates `LoadableComponent`) (#9515)
  chore(linting): enable selector-pseudo-element-colon-notation rule (#9518)
  refactor(storybook): refactor tooltip simple story interface (#9538)
  refactor(dom): consolidate transition/animation waiting utils (#9341)
  refactor(storybook): build storybook simple story args interfaces using component class (#9457)
  chore: release next
  fix(block): add accessible label for slotted controls (#9502)
  feat(action-bar, action-pad): add expandLabel and collapseLabel to messages (#9497)
  chore: release next
  feat(action-menu, combobox, dropdown, input-date-picker, popover): allow logical placements for flipPlacements property. #8825 (#9490)
  fix(popover): correct border radius on close button (#9485)
  fix(list-item): hide nested list items by default (#9474)
  refactor: move component types into component specific interfaces files (#9527)
  chore: release next
  fix(alert): pause auto-close alert when link focused (#9503)
  refactor(storybook): consolidate storybook and component types (#9500)
  refactor(calcite-block-section,calcite-card): consolidate interfaces imports (#9517)
  chore: release next
  fix(block-section): restore block toggling when clicking on the header switch (#9472)
  chore: release next
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Dashboards Issues logged by ArcGIS Dashboards team members. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive
Projects
None yet
Milestone
2024-06-25 - Jun Release
Development

No branches or pull requests
4 participants
@driskull @geospatialem @jmanke @DitwanP