refactor(storybook): consolidate storybook and component types #9500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aPreciado88
requested review from
benelan,
jcfranco,
driskull,
geospatialem and
a team
as code owners
github-actions
bot
added
the
refactor
…eciado88/9418-consolidate-storybook-and-component-types
aPreciado88
added
pr ready for visual snapshots
jcfranco
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
Aside from a few cleanup comments, this LGTM!
@anveshmekala @driskull @Elijbet @eriklharper @macandcheese can you give this a quick look? 👀
| @@ -53,7 +53,10 @@ export class TileGroup implements InteractiveComponent, SelectableGroupComponent | |||
| * | |||
| * Use `"horizontal"` for rows, and `"vertical"` for a single column. | |||
| */ | |||
| @Prop({ reflect: true }) layout: Exclude<Layout, "grid"> = "horizontal"; | |||
| @Prop({ reflect: true }) layout: Exclude< | |||
There was a problem hiding this comment.
Based on this PR, I think it's better if we change this to Extract instead. Applies to other relevant exclusions.
| @@ -14,15 +14,14 @@ import { | |||
| import { focusFirstTabbable, toAriaBoolean } from "../../utils/dom"; | |||
| import { isActivationKey } from "../../utils/key"; | |||
| import { connectLocalized, disconnectLocalized, LocalizedComponent } from "../../utils/locale"; | |||
| import { FlipContext } from "../interfaces"; | |||
There was a problem hiding this comment.
Can we submit these import-only changes separately?
| @@ -1,4 +1,2 @@ | |||
| export type ArrowType = "inline" | "edge" | "none"; | |||
There was a problem hiding this comment.
We can leave component-specific types where they are. Anything that's shared should go in src/components/interfaces.ts. Some new types might need to be moved to component-level interfaces.ts files.
alisonailea
approved these changes
Jun 5, 2024
aPreciado88
deleted the
aPreciado88/9418-consolidate-storybook-and-component-types
branch
benelan
added a commit
that referenced
this pull request
Jun 10, 2024
…orkflow * origin/main: (26 commits) revert: refactor: add simpler `componentFocusable` util (deprecates `LoadableComponent`) (#9515) chore(linting): enable selector-pseudo-element-colon-notation rule (#9518) refactor(storybook): refactor tooltip simple story interface (#9538) refactor(dom): consolidate transition/animation waiting utils (#9341) refactor(storybook): build storybook simple story args interfaces using component class (#9457) chore: release next fix(block): add accessible label for slotted controls (#9502) feat(action-bar, action-pad): add expandLabel and collapseLabel to messages (#9497) chore: release next feat(action-menu, combobox, dropdown, input-date-picker, popover): allow logical placements for flipPlacements property. #8825 (#9490) fix(popover): correct border radius on close button (#9485) fix(list-item): hide nested list items by default (#9474) refactor: move component types into component specific interfaces files (#9527) chore: release next fix(alert): pause auto-close alert when link focused (#9503) refactor(storybook): consolidate storybook and component types (#9500) refactor(calcite-block-section,calcite-card): consolidate interfaces imports (#9517) chore: release next fix(block-section): restore block toggling when clicking on the header switch (#9472) chore: release next ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #9418
Summary
packages/calcite-components/.storybook/interfaces.tsandpackages/calcite-components/src/components/interfaces.ts