feat(split-button): add placement and flipPlacements property #9548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
enhancement
driskull
added
pr ready for visual snapshots
jcfranco
approved these changes
Jun 10, 2024
| @@ -168,6 +176,31 @@ export const iconStartAndIconEnd = (): string => html` | |||
| </div> | |||
| `; | |||
|
|
|||
| export const placementTopStart = (): string => html` | |||
There was a problem hiding this comment.
Do you think we could replace this and similar tests by enhancing the [floatingUI common test helper](https://github.com/Esri/calcite-design-system/blob/main/packages/calcite-components/src/tests/commonTests/floatingUI.ts? If so, we can create a separate issue for this.
There was a problem hiding this comment.
yeah that makes sense as a separate issue. Can you create one?
benelan
added a commit
that referenced
this pull request
Jun 10, 2024
* origin/dev: build(deps): update dependency markdownlint-cli to v0.41.0 (#9531) chore: add translations (#9461) build(deps): update dependency @whitespace/storybook-addon-html to v6.1.1 (#9510) build(deps): update dependency chromatic to v11.5.3 (#9519) build(deps): update dependency jsdom to v24.1.0 (#9530) build(deps): update dependency semver to v7.6.2 (#9508) build(deps): update dependency dayjs to v1.11.11 (#9452) build: update browserslist db (#9528) build(deps): update dependency @cspell/eslint-plugin to v8.8.4 (#9509) build(deps): update dependency quicktype-core to v23.0.170 (#9507) fix(combobox): open the component when typing within it (#9543) feat(split-button): add placement and flipPlacements property (#9548) ci(prerelease): use absolute path to publish script (#9546) ci: rework release workflow making dev the default branch (#9514)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #9542
Summary