Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Definition properties needed to support new Hub chart card w/o overrides #375

Closed
tomwayson opened this issue Dec 22, 2017 · 7 comments
Closed

Comments

@tomwayson
Copy link
Member

tooltip.enabled (or popup.enabled?)
legend.enabled

I think we can add both of the above and fill in further properties later (i.e. flesh out other tooltip options in #341).

Beyond those we'll need new properties for the following:

  • something to control the visibility/text of axis titles, maybe an axes hash?
  • something to control these color properties backgroundColor, color, colors, maybe a style hash?

For those, I'm less sure of what the JSON should look like, and am open to suggestions (@ajturner, @benstoltz).

@tomwayson tomwayson added this to the v1.0.0 milestone Dec 22, 2017
@tomwayson
Copy link
Member Author

@benstoltz
Copy link
Member

Another color property would be hoverColor or something to that effect.

If we called it style then I'd want it to handle all things, like font family, colors, etc. At least imo

@tomwayson

@tomwayson
Copy link
Member Author

tomwayson commented Jan 9, 2018

If we called it style then I'd want it to handle all things

yes, that was what I had in mind

@benstoltz
Copy link
Member

Re legend: right now we have legends turned off for single series charts. If we introduce an enabled/disabled feature should we keep legends turned off for single series charts by default?

@tomwayson
Copy link
Member Author

Yes, keep current defaults, but let the new legend property override them.

so for single series, if someone passes in legend: { enable: true } show the legend. Likewise, for multi-series, if someone passes in legend: { enable: false } don't show it.

@tomwayson
Copy link
Member Author

To be clear:

If we called it style then I'd want it to handle all things

yes, that was what I had in mind

I mean eventually those would live under style. For now all we need is backgroundColor, color, colors

@tomwayson
Copy link
Member Author

Closing this issue, as the outstanding work is now captured in #436 and #435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants