Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the state of m_b_union_all_dimensions in OperatorUnionCursor #199

Open
tdcmeehan opened this issue Aug 28, 2018 · 1 comment
Open

Comments

@tdcmeehan
Copy link

tdcmeehan commented Aug 28, 2018

I was looking at the source for OperatorUnionCursor, and found m_b_union_all_dimensions flag. I am curious what the intent of it is? It seems to always be set to false. Is the intent to one day allow support for OperatorUnionCursor to support multiple dimensions (as opposed to current behavior, which drops the lowest dimensions)? If that's what it was intended for, do we think it's feasible to modify this code to allow setting it to true when we want to allow support for unioning multiple dimensions of geometries with this operator?

@stolstov
Copy link
Member

Yes, this is unfinished code, I forgot to remove it. We don't have a requirement to support this behavior in the OperatorUnion. The only place where this behavior was needed is OGCGeometry.union, where it was done in a custom way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants