searchAnnotations should handle user request errors and maybe pass auth along to request for users

[tomwayson]

This line sends an unauthenticated request:

hub.js/packages/annotations/src/search.ts

Line 59 in 0ad455a

const getUserInfo = users.map(name => getUser(name));

I think that will only work for public user accounts. Other user accounts prob return 403.

Also https://github.com/Esri/arcgis-rest-js/pull/243/files is blowing up my https app. Generally it would be a good idea to handle errors for each user request so we still return annos and whatever users are visible. Makes me pine for allSettled.

[ajturner]

This is also an issue if the user no longer exists.

For now, I suggest simply

const getUserInfo = users.map(name => getUser(name).catch(error => return null);

and don't push null into the included[] array.

[tomwayson]

I think this becomes more important w/ the upcoming changes in ArcGIS Online that will prohibit anonymous searches for users.

[alexus37]

Another issue in the search function is the getUser function is only called by name (string) and no IGetUserOptions are passed. This crashes if the users from the annotations are from a different portal. The authentication and the portal should be passed on.

[tomwayson]

@alexus37 I'd gladly help you land a PR. :)

[alexus37]

@tomwayson Check out #167

[tomwayson]

@alexus37 sorry for the delay, but we've had a couple of high priority releases/patches of this library that had to go out in the last couple days. I'll look at your PR later today and get it released soon.

[tomwayson]

@alexus37 this was released in v2.2.3

[sandromartis]

Made a new PR #171 to also pass the portal into getUser