Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Partial #635 - also directs logging to stdout #636

Merged
merged 1 commit into from Oct 27, 2017
Merged

Partial #635 - also directs logging to stdout #636

merged 1 commit into from Oct 27, 2017

Conversation

csmoore
Copy link
Member

@csmoore csmoore commented Oct 26, 2017

See #635

Types of changes

  • Enhancement
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@csmoore csmoore requested review from mfunk and ACueva October 26, 2017 18:31
mfunk
mfunk approved these changes Oct 26, 2017
View reviewed changes
Copy link
Member

@mfunk mfunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@csmoore csmoore merged commit ab2f497 into dev Oct 27, 2017
@csmoore csmoore deleted the csm/#635-logging-enhancement-part1 branch October 27, 2017 12:53
@csmoore csmoore mentioned this pull request Nov 3, 2017
Merged
7 tasks
@csmoore csmoore mentioned this pull request Dec 5, 2017
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfunk mfunk mfunk approved these changes

@ACueva ACueva Awaiting requested review from ACueva

Assignees
No one assigned
Labels
T - unit test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@csmoore @mfunk @elinz