String parameter for eval_algo_str methods in Python #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome contribution @alexander-g ! I have been meaning to get around this one for a while, so this is a great addition as it will make it much more convenient when passing raw shader string. I will run the tests locally and will merge - I will be planning to do another release of 0.5.2 / 0.6.0 next weekend |
axsaucedo
approved these changes
Dec 28, 2020
There was a problem hiding this comment.
all tests pass - lgtm. Thanks for the contribution @alexander-g !
|
Can I get @alexander-g contact nummper please , how can I contact without him ? Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added string parameters for all
eval_algo_strmethods as described in #93 . I have kept the previous methods that accept lists but I guess they are redundant now? Shall I remove them?