Too many warnings #183
Merged
Too many warnings #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axsaucedo
requested changes
Mar 11, 2021
src/Sequence.cpp
Outdated
| @@ -27,7 +27,8 @@ Sequence::~Sequence() | |||
| { | |||
| KP_LOG_DEBUG("Kompute Sequence Destructor started"); | |||
|
|
|||
| this->destroy(); | |||
| if (this->mDevice) | |||
There was a problem hiding this comment.
add parenthesis to match style
src/Sequence.cpp
Outdated
| @@ -81,7 +82,8 @@ void | |||
| Sequence::clear() | |||
| { | |||
| KP_LOG_DEBUG("Kompute Sequence calling clear"); | |||
| this->end(); | |||
| if (this->isRecording()) | |||
There was a problem hiding this comment.
add parenthesis to match style
src/Tensor.cpp
Outdated
| @@ -28,7 +28,8 @@ Tensor::~Tensor() | |||
| KP_LOG_DEBUG("Kompute Tensor destructor started. Type: {}", | |||
| this->tensorType()); | |||
|
|
|||
| this->destroy(); | |||
| if (this->mDevice) | |||
There was a problem hiding this comment.
add parenthesis to match style
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a Manager is destroyed, the Manager manually destroys Tensors and Sequences. Then the Tensor and Sequence destructors kick in and want to destroy even more, but there is nothing left to destroy so a warning is issued for every Tensor and Sequence. This is very annoying in interactive Python, esp when having a lot of Tensors.
Also, for anonymous sequences
end()is called too often and results in another warning.Added checks to avoid this.