Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle lowercase hex values in NoC ID #36

Closed
mattpopovich opened this issue May 2, 2019 · 1 comment
Closed

Handle lowercase hex values in NoC ID #36

mattpopovich opened this issue May 2, 2019 · 1 comment

Comments

@mattpopovich
Copy link

Any reason why we can't call .upper() here to avoid getting the error here if the user uses lowercase hex values?
Or add lowercase a-f to the regex?
@mbr0wn
Copy link
Contributor

mbr0wn commented May 2, 2019

No reason. It's a good point. I'll add a-f.

@mbr0wn mbr0wn closed this as completed May 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mbr0wn @mattpopovich