Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some characters inserted with AltgGr don't work #768

Closed
vvollaro opened this issue Apr 17, 2019 · 30 comments
Closed

Some characters inserted with AltgGr don't work #768

vvollaro opened this issue Apr 17, 2019 · 30 comments

Comments

@vvollaro
Copy link

vvollaro commented Apr 17, 2019

Version: 1.0.73
Platform: win32 10.0.17134
Plugins: none

On azerty keyboard, some additional characters can be inserted using a AltGr+Key (in fact the Alt key on the right). See this image for details for the french azerty layout for example.

In my case two keys are not correctly inserted, the characters ~ and `. For example when pressing the AltGr+é keys, the ~ should be displayed, but the é char is inserted instead. If I press space bar, the ~ is finally inserted.

When testing with the basic git bash window, the behavior is when pressing first the AltGr+é key, nothing is displayed, pressing bar space displays the "~" char. This the same behavior in Linux terminals:

tild_bug

@vvollaro vvollaro changed the title Some characters inserted with AltgGr doesn't work Some characters inserted with AltgGr don't work Apr 17, 2019
@bahamut45
Copy link

+1 I have the same problem

@gdlx
Copy link

gdlx commented May 24, 2019

This is the same issue I opened on VScode: microsoft/vscode#68262

@gdlx
Copy link

gdlx commented May 28, 2019

Same issue with the ` character with AltGr + 7

@stale
Copy link

stale bot commented Jul 28, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks unless you comment.
Thank you for your contributions.

@stale stale bot added the S: Stale This issue had no activity for two months label Jul 28, 2019
@bcxpro
Copy link

bcxpro commented Jul 28, 2019

Still happens to me on the Spanish keyboard

@stale stale bot removed the S: Stale This issue had no activity for two months label Jul 28, 2019
@vvollaro
Copy link
Author

vvollaro commented Jul 29, 2019

I see that the microsoft terminal has the same problem and has a potential fix: microsoft/terminal#521

Maybe it is interesting to check their solution. Meanwhile, I use the combination of ctrl+alt instead and it works for me.

@stale
Copy link

stale bot commented Sep 27, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in two weeks unless you comment.
Thank you for your contributions.

@stale stale bot added the S: Stale This issue had no activity for two months label Sep 27, 2019
@vvollaro
Copy link
Author

Always reproduced

@stale stale bot removed the S: Stale This issue had no activity for two months label Sep 27, 2019
@bcxpro
Copy link

bcxpro commented Sep 27, 2019

Still happens to me on the Spanish keyboard

@gdlx
Copy link

gdlx commented Sep 27, 2019

Still relevant on 1.38.1 with French keyboard 😿

@fle108
Copy link

fle108 commented Oct 1, 2019

same problem on 1.0.91

@Renji-FR
Copy link

Me too on 1.0.103.3882.

@mr-potato-head
Copy link

Same problem on a french keyboard.

@Renji-FR
Copy link

Renji-FR commented Mar 4, 2020

A workround is to use Microsoft Keyboard Layout Creator to create a custom layout with tilde ~ configured without option "dead key". Under MSKLC, select ALTGR and make right click on ~ to unselect "Set as dead key"

@roonie007
Copy link

@Renji-FR Dude you are the best, I have been struggling with this since the problem started on VsCode

@Raton-Laveur
Copy link

Reproduced on VS Code 1.50.1 Win10 20H2. Regional settings are Windows display US, keyboard Azerty France.

@Eugeny
Copy link
Owner

Eugeny commented Aug 22, 2021

I've just pushed a potential fix for these dead key related issues - would love to hear your feedback as soon as the nightly is built

EDIT: builds are up at https://github.com/Eugeny/tabby/actions/runs/1156041791

@enodr
Copy link

enodr commented Aug 23, 2021

Just downloaded the windows portable version and unfortunately the fix does not work for me.

The xterm.js pull request you made to fix the issue has not yet been merged, has it?

@Eugeny
Copy link
Owner

Eugeny commented Aug 23, 2021

@enodr dang. The fix isn't in xterm yet, but it's in tabby's fork.

@Eugeny Eugeny reopened this Aug 23, 2021
@Eugeny
Copy link
Owner

Eugeny commented Aug 24, 2021

@enodr I've just double-checked this with the current nightly on macOS and Windows and it works - are you sure you've grabbed the right version?

@enodr
Copy link

enodr commented Aug 24, 2021

In fact on a AZERTY layout, with the current nightly build, only two keys don't behave correctly: the tilde ~ and the backtick `

The key "2" on a FR layout is:
2 (upper)
é (lower)
~ (need to press ALT-GR + space or ALT-GR + letter for ñ, õ, ã, etc)

image

When typing a ALT-GR + 2, Tabby outputs é and then after space press it outputs ~ and you now have é~ in the term instead of just ~. Same for backtick (key 7), you will end up with è`.

Unfortunately these two chars are keys used very often on linux terminal. Could that be yet another bug in xterm.js?

@bcxpro
Copy link

bcxpro commented Aug 24, 2021

Just tested with this tabby-1.0.156-nightly.0-portable and my Spanish keyboard. AltGr+4 and then SPACE should display ~. It displays 4~

Eugeny added a commit that referenced this issue Aug 25, 2021
@Eugeny
Copy link
Owner

Eugeny commented Aug 25, 2021

New potential fix available in the nightly: https://github.com/Eugeny/tabby/actions/runs/1167927546

GitHub
A terminal for a more modern age (formerly Terminus) - #768 - fixed altgraph modifier handling · fa66c96

@enodr
Copy link

enodr commented Aug 26, 2021

Well done it works!

@Eugeny Eugeny closed this as completed Aug 26, 2021
@Eugeny
Copy link
Owner

Eugeny commented Aug 26, 2021

Thanks for testing!

@bcxpro
Copy link

bcxpro commented Aug 26, 2021

I just tested it on the Spanish keyboard. It definitely improved a lot but there is still an odd behaviuor.

This part is great:
AltGr+4 Space Expected: ~ Actual: ~
AltGr+4 a Expected: ã Actual: ã
AltGr+4 n Expected: ñ Actual: ñ
AltGr+4 o Expected: õ Actual: õ
all the characters like that seem to work fine now.

AltGr+4 i Expected: ~i Actual: ii
AltGr+4 p Expected: ~p Actual: pp
and so on...

It seems that for these characters that do not support a ~ above instead of displaying ~ and the character it duplicated the character.

@Eugeny Eugeny reopened this Aug 26, 2021
@Eugeny Eugeny closed this as completed in 4ff5dea Aug 28, 2021
@Eugeny
Copy link
Owner

Eugeny commented Aug 28, 2021

Build ready: https://github.com/Eugeny/tabby/actions/runs/1177141278

GitHub
A terminal for a more modern age (formerly Terminus) - fixed #768 again · 4ff5dea

@enodr
Copy link

enodr commented Aug 28, 2021

Works perfectly now, thanks.

@Bloopps
Copy link

Bloopps commented Aug 31, 2021

Hi,
Sorry but for me the last nightly build does not fix the issue. #4433

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests