Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

voices are not working correctly in vr mode with new dlc #54

Open
theboobness opened this issue Apr 30, 2017 · 10 comments

Comments

Projects
None yet
9 participants
@theboobness
Copy link

commented Apr 30, 2017

Hi Eusth, the voices aren't working correctly when I go in an H scene. there would be multiple voices (4 or more) playing at the same time. In normal mode without vr, the game plays fine. Is there any way to fix this?

@Eusth

This comment has been minimized.

Copy link
Owner

commented Apr 30, 2017

Completely untested, but try this: HoneySelectVR_0.6.1.zip

@theboobness

This comment has been minimized.

Copy link
Author

commented Apr 30, 2017

Thank you!! it works perfectly now!!

@plasticfant

This comment has been minimized.

Copy link

commented May 11, 2017

I posted this to the honeyselect subreddit so more VR users can test.
https://www.reddit.com/r/HoneySelect/comments/6930pt/anyone_able_to_get_vr_working_with_the_party_dlc/

As always, thank you Eusth for your huge contribution to VR

@theboobness theboobness changed the title voices are working correctly in vr mode with new dlc voices are not working correctly in vr mode with new dlc May 12, 2017

@deinlandel

This comment has been minimized.

Copy link

commented May 21, 2017

@Eusth Could you please tell what did you patched? I use custom HoneySelect plugin built from sources, and it seems that these changes are not published on Github...

@Eusth

This comment has been minimized.

Copy link
Owner

commented May 21, 2017

Yup, because it breaks the positional audio. Not gonna add the "fix" to the code. Simply remove the VoiceShim line in HoneySelectVR.cs.

@Devilsbane99

This comment has been minimized.

Copy link

commented Jun 11, 2017

Thank you so much for this Eusth! Working great!

@ice36bc

This comment has been minimized.

Copy link

commented Jul 20, 2017

Thanks this the sound is working right now.

@Kin20101

This comment has been minimized.

Copy link

commented Jul 24, 2017

Thanks for update = v =

@plasmacut

This comment has been minimized.

Copy link

commented Jul 13, 2018

Does that mean there is no working positional audio for 1.20? Also my folder does not contain a HoneySelect.cs file. When using VR patch 0.6 there is also no positional audio unless it's used on version 1.1 for me.

@ZerothAngel

This comment has been minimized.

Copy link

commented Jun 5, 2019

The reason positional audio doesn't work in 1.20 is because a new bool force2D parameter was added to the Play and OnecePlayChara methods in Manager.Voice. For whatever reason, OnecePlayChara is called with this set to true during H-scenes.

I managed to fix this in a quick & dirty way (see my fork), but:

  1. I decided to use Harmony for runtime patching (just to learn it).
  2. I always set force2D to false.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.