Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supported versions of node not documented #6

Closed
hughrawlinson opened this issue Aug 13, 2017 · 1 comment
Closed

Supported versions of node not documented #6

hughrawlinson opened this issue Aug 13, 2017 · 1 comment

Comments

@hughrawlinson
Copy link

Wish doesn't work on Node v7.5.0 - I think Node changed the Error format and now the regex here doesn't match. This issue could be resolved by either fixing the regex or by specifying engines in package.json.

Great library, awesome book! Thanks!
@EvanBurchard
Copy link
Owner

Hey. Thanks for letting me know. @blrobin2 was kind enough to submit a PR with a better regex but setting a minimum version is a really nice touch, so I added it.

Thanks again, and happy reading!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@EvanBurchard @hughrawlinson