Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Shell Model Fetching #33

Closed
Eve-ning opened this issue Aug 27, 2023 · 0 comments · Fixed by #29 or #44
Closed

Implement Shell Model Fetching #33

Eve-ning opened this issue Aug 27, 2023 · 0 comments · Fixed by #29 or #44

Comments

@Eve-ning
Copy link
Owner

Currently, we have train.py setting the model path on the .env file.

I don't think it's a great approach, as it widens the scope of train, which should just train the model, make the model, and possibly return the model path. The problem is that the model path return is not trivial, thus we resorted to I/O-ing to the .env file.

A better solution is to specify a unique model name, which is the pipeline run id, then we can grep the model from opal/models.

@Eve-ning Eve-ning added this to the pipeline-automation milestone Aug 27, 2023
@Eve-ning Eve-ning linked a pull request Aug 28, 2023 that will close this issue
@Eve-ning Eve-ning reopened this Aug 29, 2023
@Eve-ning Eve-ning added the ui/ux label Aug 31, 2023
@Eve-ning Eve-ning linked a pull request Sep 5, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant