Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Details screen toolbar alarm icon is not updated #254

Closed
johnjohndoe opened this issue Mar 30, 2020 · 1 comment
Closed

Details screen toolbar alarm icon is not updated #254

johnjohndoe opened this issue Mar 30, 2020 · 1 comment
Assignees
@johnjohndoe
Labels
Alarms The session reminder feature Bug report Supposed to be assigned to issues. Session details The screen with all information about the session.

Comments

@johnjohndoe
Copy link
Member

johnjohndoe commented Mar 30, 2020 •
edited
Loading

Environment

How to reproduce

  1. Build and install cccamp2019 flavor
  2. Tap a session
    • The detail screen opens
    • The toolbar alarm icon is unset, + symbol
  3. Long tap the session in the schedule view, select add alarm, pick any time
    • The session in the schedule view shows an alarm icon

Observed behavior

  • The toolbar alarm icon of the details screen is unset, + symbol
    The toolbar alarm icon of the details screen is unset, + symbol

Expected behavior

  • The toolbar alarm icon of the details screen is set, - symbol
    The toolbar alarm icon of the details screen is set, - symbol

First analysis

  • The error occurs because the MyApp.lectureList is used to store an in-memory copy of the sessions being displayed. When a user acts on a session (setting an alarm) this change must be written to this list. This "synchronization" mechanism has been broken in the referenced commit.

Related

/cc @cketti
@johnjohndoe johnjohndoe added the Bug report Supposed to be assigned to issues. label Mar 30, 2020
@johnjohndoe johnjohndoe pinned this issue Jul 24, 2020
@johnjohndoe johnjohndoe unpinned this issue Aug 8, 2020
@johnjohndoe johnjohndoe added the Alarms The session reminder feature label Feb 9, 2021
@johnjohndoe johnjohndoe added the Session details The screen with all information about the session. label Nov 2, 2021
@johnjohndoe johnjohndoe self-assigned this Sep 17, 2022
@johnjohndoe
Copy link
Member Author

Closing as fixed

This has automatically been fixed by refactoring the app architecture to unidirectional data flow in last month. Checked with Version 1.55.0 on Android 12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnjohndoe johnjohndoe

Labels
Alarms The session reminder feature Bug report Supposed to be assigned to issues. Session details The screen with all information about the session.
Milestone
No milestone
Development

No branches or pull requests
1 participant
@johnjohndoe