Include duration in event detail view #227
Conversation
|
@andreaswolf Thank you for your contribution. This feature is closely related to a recent change in the app which you can find in pull request #192 and issue #10. I would like to raise the question if a visual separation of date/time and duration makes sense here. As a separator a well chosen icon might even help with that. In that case you would have to create a new view for the duration instead of concatenating the date/time and duration texts. - What do you think about this? Additional, please provide before and after screenshots to ease the review process and to have the visual state of the app being documented. Please check the "extreme" values such as a very short duration such as 5min and very long session such as 420min. |
|
@johnjohndoe Thanks for the feedback. I also thought about this separation, I just wanted to keep the effort as low as possible for now – but it definitely makes sense to separate it. I'll add screenshots once the changes are done. |
|
I haven't though about a good icon yet. We should discuss this up front. Research what other apps use might be helpful. Please keep in mind that the calendar icon is already used for the "add to calendar" action and therefore using it in two contexts might be confusing. |
|
@andreaswolf Please join the discussion in #231. I also added the issue to your pull request description. |
johnjohndoe
added
the
Date & time
johnjohndoe
added
the
Session details
|
Is that ready to be reviewed? If so, could you please resolve the conflict. |
|
The conversion here stopped at the end of 2019 as you can see above. In my opinion the PR is not ready. We still need to discuss how the visual change should look in the end. Not sure if @andreaswolf wants to continue here. |
johnjohndoe
added
the
Stale
Description
Includes the event duration after the start time in the detail view's top bar
Before
No duration was shown
After
The duration (e.g. "60 min") is shown after the start time.
Related